Github Push to hicknhack-software/Qt-Creator
-
Fix installing just a library in plugin install wizard
It is possible to just select a plugin library in the plugin install
wizard, and that worked by just copying the library over.
Amends be2e5262c73ef747511a10e04a36338d3d49412e
that introduced a crash for that case, by unconditionally using the
PluginSpec instance that was only created for the "archive" case.
Instead of skipping the check archive step, also try to read a
PluginSpec for pure library files. That has the advantage that we do some
basic checks for them too, and that we have the PluginSpec instance
available for the later code.
Change-Id: I23286d81de54c08d4735c9bcdb2368c8b6097408
Reviewed-by: Marcus Tillmanns -
AutoTest: Fix possible crash
Using the same snapshot may lead to an invalid
access violation.
Change-Id: If434555781be5b8281432ff9f14fba3ae41df846
Reviewed-by: Christian Kandeler -
PluginInstallWizard: Remove unneeded code
Remove an unneeded `if` and actually no need to override a method that
just calls the parent implementation.
Change-Id: I9f17ed1587227ce8f0ba14cdeb72dd32b73513ba
Reviewed-by: hjk -
CppEditor: Fix test string
The raw string literal syntax is awesome.
Change-Id: Icd2677b40393eb66014755ef411473b236e6b19f
Reviewed-by: Christian Stenger -
winpty: Fix MSVC warnings
C4530: C++ exception handler used, but unwind semantics are not enabled. Specify /EHsc
In winpty this has already been fixed for winpty, but winpty-agent was
not covered.
Change-Id: Ic98e32c56fb33f6680303d790d1b6b2078557cc1
Reviewed-by: Marcus Tillmanns -
Fix issues discovered by sanitybot, enable clicking of thumbnails
Fixes: QTCREATORBUG-32134
Change-Id: Id452207bda0197340490efd3d8ea6faeff1e3e4e
Reviewed-by: Alessandro Portale -
UpdateInfo: Localize last/next check dates in settings
Fixes: QTCREATORBUG-32094
Change-Id: I52049575f5a6ccd983cce6118f20dc10ba5d7247
Reviewed-by: Christian Stenger -
CppEditor: Try harder to prevent code folding in ifdefed-out code
The syntax highlighter can re-run after the semantic highlighter,
overwriting its changes.
Amends 2bfa16daa16bd578eb83561f76e14ad55e38678d.
Change-Id: I1c4efa5033ef4152e2d77dc2d99edbceac4e13c1
Reviewed-by: David Schulz -
PluginInstall: Prevent selection of installed plugin
Prevent selection of plugin libraries that are already in any plugin
directory. Check if they can resolve their dependencies as well.
Also generally check if a plugin with the same ID is already installed.
Change-Id: I0cdc0b3e0eba8682f90db7a460974106a6d5e44c
Reviewed-by: Marcus Tillmanns -
Android: Fix a possible crash after reloading packages
The AndroidSdkManager::packagesReloaded() signal emission will
trigger the connected slots in this order:
1. AndroidSettingsWidget::showEvent()'s lambda
2. AndroidSdkModel::refreshData()
However, the 1st slot may execute the nested event loop which
will cause the other GUI parts to be repainted. Since AndroidSdkModel
wasn't notified yet about the packagesReloaded(), it still holds the
data to the already deleted packages. The repaint will lead to
reading the data from already deleted objects.
The fix is to ensure the order of called slots is opposite,
by queueing a call to AndroidSettingsWidget::showEvent()'s lambda.
Change-Id: I090f0a44c3785a711a08f0eb985e2025cf3a923a
Reviewed-by: Eike Ziller -
PluginManager: Write plugin id, not name, to startup check
We write information about the currently "starting" plugin, so if that
crashes we notice that at the next startup and ask the user if they
really want to try to load that plugin again.
Nowadays we must write the id(), not the name() anymore.
Change-Id: Ibdee163eb5d58820347f6e8e11b8a3d4f29ff53a
Reviewed-by: Marcus Tillmanns -
LSP: fix typo in condition
Fix a typo in a condition that ended up always being true.
Amends 1221a9678de22badd0a5f73dee452d9bbef9c4b8.
Change-Id: Ib1b0151f5ba14d753fe1610f85e7d16f3c91184e
Reviewed-by: David Schulz -
Editor: use detected indentation by default
This removes the undescribed Mixed tab settings option. It was unclear
and undocumented what this option actually means.
In theory this option tries to detect whether tabs or spaces are used
for indentation around a specific position in the document. This now
conflicts with the automatic auto detection which scans the complete
document. That auto detection not just detects whether tabs are used but
also the indent depth. Having a source document with a different indent
depth is arguably a more common use case than a source file with mixed
tabs and spaces for indentation. So in order to not confuse the user
with to many unclear magic options that might interfere with each other
the mixed tab settings option was removed in this change.
Fixes: QTCREATORBUG-11575
Fixes: QTCREATORBUG-11675
Fixes: QTCREATORBUG-19576
Fixes: QTCREATORBUG-25628
Change-Id: Ib95662ade38d0384d503e9a7b99f54ea4b416f68
Reviewed-by: Christian Stenger -
Editor: Add option to hide tab setting button
Change-Id: Idba9e5d6c080f51342dde20bc6ab6e82f12e3cd5
Reviewed-by: Christian Stenger -
TextEditor: Respect and store autodetect setting
Amends 08a66b778064ece5f01ee3323d8a5b5171b02c09.
Change-Id: I250fa295cfd9270c1598bcda451bc5b6fd19804c
Reviewed-by: David Schulz -
LSP: fix typo in condition
Fix a typo in a condition that ended up always being true.
Amends 1221a9678de22badd0a5f73dee452d9bbef9c4b8.
Cherry-picks 6cdacdacef455a32aaa7979861340ce1e8486c69.
Change-Id: Ib1b0151f5ba14d753fe1610f85e7d16f3c91184e
Reviewed-by: Eike Ziller -
RemoteLinux: Use the 'local' executable as remote executable
... for real remote builds with build and run device the same.
This brushes over the fact that the deployment data stays currently
empty for remote cmake builds.
Change-Id: I7bfa2907791306a66f8b94c5f8851498284539ca
Reviewed-by: Christian Kandeler -
Merge remote-tracking branch 'origin/15.0'
Conflicts:
src/plugins/languageclient/languageclientmanager.cpp
Change-Id: I87d44574e8c6627cb97c44d4c68997fd28799bf3 -
Utils: Merge one FileReader use in its only user
Change-Id: Ie9ab42b33c0fe95bb17d82f07ad83a32324e459c
Reviewed-by: Eike Ziller -
TextEditor: avoid leaking the tab settings button menu
Fixes: QTCREATORBUG-32161
Change-Id: I499a24d8ed80d710df8b45ad30fa5c68a4acfb20
Reviewed-by: Eike Ziller