Github Push to hicknhack-software/Qt-Creator
-
Wizards: Bump install-dev-package to v1.6
We were having issues with the download of the Qt Creator packages
failing. The new version of the install-dev-package script has more
error output that might help with tracking down the issue as it
is intermittent.
Change-Id: I677bbf893215a056bea96feecef9bcd241cf85d6
Reviewed-by: Eike Ziller
-
Debugger: Fix "{En,Dis}able All Breakpoints" context menu action
The actual set of breakpoints to which the option was applied could
have been different than the one used at the time of the creation
of the context menu due to background activity. Found by crash reporter.
Change-Id: I43a75c8659fe8a11988fa081022965db4ce9233c
Reviewed-by: Eike Ziller
-
CppEditor: Fix "inline" placement also when moving definitions
Not just when creating them.
Amends 9c4ba3ff21fc4691adb0017cd9ec92c567ba7bf8.
Task-number: QTCREATORBUG-31678
Change-Id: If1dbb1d5e247543fa91d3c086622926f5daeca93
Reviewed-by: Christian Stenger
-
CMakePM: Use qobject_cast instead of static_cast for CMakeProject
Attempt at fixing sentry issue QT-CREATOR-6R
Change-Id: Ia19ec8b0507331e8531d7ffec2c86f203ecae0db
Reviewed-by: Marcus Tillmanns
-
OpenEditorsWindow: Fix crash when entries are removed
behind the back of the window.
The open editors window (that appears on ctrl+tab / opt+tab) keeps
pointers to Entry items from the DocumentModel. Usually that is no
problem, because the editor manager hides the open editors window before
closing editors. But there was an issue with suspended entries, that can
be reproduced with some effort, e.g.
- Give e.g. "Unload/Close Project" a shortcut that you can trigger while
the popup is open, like Opt+K on macOS, or Ctrl+Shift+J on Lin/Win
- Open a project and a few files from the project
- Switch the document switcher of the editor view to ""
- Close & reopen QtC, reload the session
- You should now have a few "suspended" documents, and *only* suspended
documents, since the editor view doesn't show anything
- Open the open editors window with ctrl+tab / opt+tab and trigger the
"close project" shortcut without closing the popup
- The documents and the project close, but the popup is open and shows
the old items
- The moment you press e.g. tab again to interact with the popup, it
crashes
Just close the popup if items are removed from the document model
"behind its back". Also clear all items whenever it is set invisible so
we don't have references to broken items hanging around.
Change-Id: I70853838f292235efea0561755b35c20aaa8473d
Reviewed-by: David Schulz
-
Editor: schedule rehighlight after font setting change
That rehighlight vanished in the transition between
highlighter -> async highlighterRunner -> highlight in batches
Fixes: QTCREATORBUG-32116
Change-Id: I32ac8e3dd29b10399e0c7e5626faef02e037306f
Reviewed-by: Christian Stenger
-
FakeVim: fix building tests with Qt 6.9
moc creates files using the identifier 'N' which breaks
after #define N '\n' followed by #include "xxx.moc" later.
Change-Id: I271b1f2aec737a75e5c2f8b2026056583d894b05
Reviewed-by: hjk
-
Fix compile with Qt 6.9
The QString::arg overload that accepts a base is explicitly disabled for
everything that can be cast to a QAnyStringView, so for example
T==char32_t or T==char16_t will is not usable in that overload. And the
overload that accepts those types does not allow to set the base. Fix
this by using T==int32_t or T==int16_t.
Change-Id: Ib23a2ced7e03dab6de50458d36bc27689c6f8da9
Reviewed-by: hjk
-
ClangCodeModel: Fix potential crash when canceling indexing
Change-Id: I9fe33f037fbb8b02a2890ec34c3a4f3584c4615e
Reviewed-by: David Schulz
-
libs: clang-19 compile fixes
* clang-19 seems to be stricter at instantiating code, causing compile
errors if functions might not compile
* use cpp feature detection macro instead of detecting compilers
Change-Id: I47d8b5e325e1528e672fd713d7622305ced1149d
Reviewed-by: Eike Ziller
-
Fix the loading of C++ plugins from user directory
`appInfo().userPluginsRoot` already contains the versioned directory for
the "current" version. Before adding all the backwards compatible
version directories we need to step up once.
Amends 165ad2784e41faa5b7b388a4762e4f27f93ee405
Change-Id: I73456629654ff5f65dd8a2a9c2fc1d935a600d5f
Reviewed-by: Marcus Tillmanns
-
JsonWizard: Fix warning
On macOS, pixelMetric(QStyle::PM_LayoutHorizontalSpacing) will always return -1.
```
QWidget::setMinimumSize: (/QWidget) Negative sizes (-1,-1) are not possible
QWidget::setMaximumSize: (/QWidget) Negative sizes (-1,-1) are not possible
QWidget::setMinimumSize: (/QWidget) Negative sizes (-1,-1) are not possible
QWidget::setMaximumSize: (/QWidget) Negative sizes (-1,-1) are not possible
```
Change-Id: I87d83af9f739dec6cdb898880ad8e9e9eaa411f9
Reviewed-by: Alessandro Portale
-
ProjectExplorer: Add some soft asserts in toolchain factory functions
These might help with diagnosing mysterious crashes observed on user
machines.
Task-number: QTCREATORBUG-32127
Change-Id: Ia41cb4bd1f68717cec255a131d02c3b86f87b769
Reviewed-by: Eike Ziller
-
ExtensionSystem: Add function to set terms as accepted
Change-Id: Ic6ca83a0d2b93b20178dcf3adef0156e520e79b4
Reviewed-by: Eike Ziller
-
Core: Set Terms as accepted during install wizard
Change-Id: Idff08bcbf4e425441bcc6bb22c1e9fc1978a5ea1
Reviewed-by: Eike Ziller
-
Fix Ctrl+Tab
Amends f6d57999d80c04f930916197806e3cd47b88d81c
That patch accidentally clears the document list before opening the
selected editor, instead of the other way round.
Change-Id: Ia694fe009b6922b2257da787346d3505f533a0c4
Reviewed-by: David Schulz
-
Fix installing just a library in plugin install wizard
It is possible to just select a plugin library in the plugin install
wizard, and that worked by just copying the library over.
Amends be2e5262c73ef747511a10e04a36338d3d49412e
that introduced a crash for that case, by unconditionally using the
PluginSpec instance that was only created for the "archive" case.
Instead of skipping the check archive step, also try to read a
PluginSpec for pure library files. That has the advantage that we do some
basic checks for them too, and that we have the PluginSpec instance
available for the later code.
Change-Id: I23286d81de54c08d4735c9bcdb2368c8b6097408
Reviewed-by: Marcus Tillmanns
-
AutoTest: Fix possible crash
Using the same snapshot may lead to an invalid
access violation.
Change-Id: If434555781be5b8281432ff9f14fba3ae41df846
Reviewed-by: Christian Kandeler
-
PluginInstallWizard: Remove unneeded code
Remove an unneeded `if` and actually no need to override a method that
just calls the parent implementation.
Change-Id: I9f17ed1587227ce8f0ba14cdeb72dd32b73513ba
Reviewed-by: hjk
-
CppEditor: Fix test string
The raw string literal syntax is awesome.
Change-Id: Icd2677b40393eb66014755ef411473b236e6b19f
Reviewed-by: Christian Stenger
